UX: Remember last current file and use it #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user switches from test file to implementation file, it is useful that 'Test Current File' remembers and executes the actual last test file run. Changes: - We actually match the filename against `settings['pattern']`. Not all files with a '.py' suffix are test files. - We store the last used test file in the `window.settings()` which is cheap to implement and probably the right thing.
Contributor
Author
|
For a test I would need to intercept a deferred call to super. This feels like it would take hours to get right. |
Contributor
Author
|
I get a coverage 🔴 for that. 😒 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user switches from test file to implementation file, it
is useful that 'Test Current File' remembers and executes the
actual last test file it ran.
Changes:
We actually match the filename against
settings['pattern'].Not all files with a '.py' suffix are test files.
We store the last used test file in the
window.settings()which is cheap to implement and probably the right thing.
Remove
current_test_fileproperty which was a misnomer andis now unused anyway.