Skip to content

Conversation

@kaste
Copy link
Contributor

@kaste kaste commented Dec 11, 2018

Instead of writing sync on 'write', write on 'flush' and 'close'.

Instead of writing sync on 'write', write on 'flush' and 'close'.
@kaste
Copy link
Contributor Author

kaste commented Dec 13, 2018

After #150 I was wondering if the output panel is a bottleneck here. With this small change, we can already make the tests faster without loosing much.

def flush(self):
	self.set_timeout_async(self._write)

would be a more aggressive solution. With that the test_user_args test from SublimeLinter runs in 0.5s (master: 6s, #150 1s).

But users prefer sync writing while tests are running even if the output runs through faster than one can read.

@randy3k
Copy link
Member

randy3k commented Dec 13, 2018

This PR looks good and I agree that self.set_timeout_async(self._write) is a bit too aggressive. Let's merge this first and consider the improvement later.

@randy3k randy3k merged commit 4b020fa into SublimeText:master Dec 13, 2018
@kaste kaste deleted the optimize-output-panel branch December 13, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants