Revert scratchness after closing view or window #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FichteFoll
requested changes
Feb 24, 2021
| class TestNewWindow(DeferrableTestCase): | ||
|
|
||
| def tearDown(self): | ||
| yield 100 |
Member
There was a problem hiding this comment.
Could you add a comment why the wait is necessary here and reference the upstream issue? We won't be able to remove this for a while until we drop compatibility with affected builds.
FichteFoll
reviewed
Mar 13, 2021
FichteFoll
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #147.
Includes #148 so the window_util tests will run.
One case is not tested. If you have an unsaved view in one window and a clone of that view in the second window, and you
close_window()the second window, the first view should not be scratch afterward. However, it doesn't look like it's possible to set that up using the Sublime API (sublimehq/sublime_text#3965). I tested it by hand and It Works On My Machine™.This PR does not expose
clone_view.