Fix a bug when changing settings in a subscribe callback. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This fixes an error case, but I still see potential for confusion when a "complex" object is constructed by the selector and modified in place, since the callback is called by reference, but that is a slightly different issue. To tackle that, we'd probably need a mutex and a second call of the selector to ensure we get two copies of the same state without relying on the data to be copyable, which is definitely not ideal. Besides, I don't think it is currently documented that the selector's result must be equatable. |
Member
Author
|
That's a good point. I think it could be handled separately from this bug, though. |
FichteFoll
approved these changes
Apr 1, 2021
This was referenced Apr 1, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the saved value of a setting wasn't updated until after the callback was completed, so if you changed that settings object inside the callback, it would incorrectly detect that the first setting had changed again.