Skip to content

Conversation

@cboillet-dev
Copy link
Contributor

@cboillet-dev cboillet-dev commented Oct 6, 2022

Description

New sdk endpoint to archive and dearchive a datamanager see asana card

When a compute task try to use an archived data_manager in raises an invalid context error.

How has this been tested?

  • unit tests

Checklist

  • [x ] changelog was updated with notable changes
  • documentation was updated

Connected-PR

  • substra-backend #521 -> this PR
  • orchestrator #54
  • substra sdk #35

@cboillet-dev cboillet-dev changed the title Feat/archive datamanager feat: archive datamanager Oct 6, 2022
@cboillet-dev
Copy link
Contributor Author

/e2e --refs orchestrator=feat/archive-datamanager,substra=feat/archive-datamanager

@Owlfred
Copy link

Owlfred commented Oct 6, 2022

End to end tests: ❌ FAILURE

Jobs status:

  • Tests Benchmark: ⏭️
  • Tests Distributed:
  • Tests Standalone:

Not this time.

@cboillet-dev cboillet-dev force-pushed the feat/archive-datamanager branch 2 times, most recently from a4a9161 to 191d726 Compare October 6, 2022 14:54
@Substra Substra deleted a comment from Owlfred Oct 7, 2022
@cboillet-dev
Copy link
Contributor Author

/e2e --refs orchestrator=feat/archive-datamanager,substra=feat/archive_datamanager

@Owlfred
Copy link

Owlfred commented Oct 7, 2022

End to end tests: ✔️ SUCCESS

“It’s alive! It’s alive!” ― Henry Frankenstein, Frankenstein

@cboillet-dev cboillet-dev force-pushed the feat/archive-datamanager branch from 5c0c294 to a009f8f Compare October 7, 2022 09:59
fix migration

fix migration post rebase

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>

fix migrations post rebase

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>

black

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>

isort

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>

lint

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>
@cboillet-dev cboillet-dev force-pushed the feat/archive-datamanager branch from a009f8f to 4ff1761 Compare October 7, 2022 10:01
Signed-off-by: Camille Boillet <camille.boillet@owkin.com>
parent_task_output_identifier = None


class ComputeTaskInputAssetFactory(factory.Factory):
Copy link
Contributor Author

@cboillet-dev cboillet-dev Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the factory is used to create task input for the context test fixture

Signed-off-by: Camille Boillet <camille.boillet@owkin.com>
Signed-off-by: Camille Boillet <camille.boillet@owkin.com>
@AlexandrePicosson AlexandrePicosson removed their request for review June 2, 2023 15:13
@guilhem-barthes
Copy link
Contributor

Thank you for your contribution! Unfortunately, due to organisational and roadmap changes, this item has been deprioritised. We currently have no bandwidth to cope with the code drift between the current code state in the last release and this PR, therefore we are closing it.

@SdgJlbl SdgJlbl deleted the feat/archive-datamanager branch July 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants