Skip to content

Conversation

@ThibaultFy
Copy link
Member

No description provided.

@ThibaultFy ThibaultFy marked this pull request as ready for review June 13, 2024 14:30

- The release 0.38.0 focuses on improving the security and limit the rights of the differents Substra pods when deployed on a cluster. The following changes have been made:

- Ressources requests and limits are now set as default for the backend and frontend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not set default values for the orchestrator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already all set for the orc if I'm not mistaken

Copy link
Contributor

@thbcmlowk thbcmlowk Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was first introduced in chart version 8.5.0 while substra 0.37.0 targets chart version 8.4.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think I would reword a bit:

Suggested change
- Ressources requests and limits are now set as default for the backend and frontend.
- CPU and memory requests and limits are now provided by default for all orchestrator, backend and frontend pods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice catch thanks !!


- The profiling of functions have been reworked to take into accound the ``builiding`` step and the ``download_function`` step.

**Backend**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only backend, but also orchestrator (or the title sounds confusing to me)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I thought it was only on backend, changed it

- Network policies have been added to limit the communication between the different pods.
- Update the different base docker images of the Susbtra components and the the user's ones to limit their vulnerabilities.

- The profiling of functions have been reworked to take into accound the ``builiding`` step and the ``download_function`` step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The profiling of functions have been reworked to take into accound the ``builiding`` step and the ``download_function`` step.
- The profiling of functions have been reworked to take into accound the ``building`` step and the ``download_function`` step.


### Added

- Documentation on how to use the Harbor profile on substra-backend ([#416](https://github.com/Substra/substra-documentation/pull/416))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned there is not more added in the documentation in the light of the release notes. Did we not agree to document the NetworkPolicy part for instance? (cc @guilhem-barthes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an entry about PSS that was not included in the changelog FYI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This should not block the release anyway, but I think we need to create follow-up issues.

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy force-pushed the chore/release-0.38.0 branch from fb0b908 to d721803 Compare June 14, 2024 08:13
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy merged commit 456b7e1 into main Jun 14, 2024
@ThibaultFy ThibaultFy deleted the chore/release-0.38.0 branch June 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants