Skip to content

Fix imperial conversion for weight on CSV export#228

Merged
dirkhh merged 1 commit intosubsurface:masterfrom
mturkia:imperialexport
Feb 26, 2017
Merged

Fix imperial conversion for weight on CSV export#228
dirkhh merged 1 commit intosubsurface:masterfrom
mturkia:imperialexport

Conversation

@mturkia
Copy link
Copy Markdown
Collaborator

@mturkia mturkia commented Feb 26, 2017

Signed-off-by: Miika Turkia miika.turkia@gmail.com

Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
@dirkhh
Copy link
Copy Markdown
Collaborator

dirkhh commented Feb 26, 2017

Can we add a test that does a CSV export in all imperial, re-imports it. And then exports this in metric. Re-imports it. and compares to the original?
Or something like that? Just to exercise this code a bit and to make sure that we'd notice if this gets broken again?
(as a new pull request, I'll merge this in a moment)

@dirkhh dirkhh merged commit 0a1224b into subsurface:master Feb 26, 2017
@mturkia mturkia deleted the imperialexport branch October 15, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants