Do not carry po2 setpoint data over dive boundaries#343
Merged
dirkhh merged 1 commit intosubsurface:masterfrom Apr 24, 2017
Merged
Do not carry po2 setpoint data over dive boundaries#343dirkhh merged 1 commit intosubsurface:masterfrom
dirkhh merged 1 commit intosubsurface:masterfrom
Conversation
The file static po2 value, used to set the setpoint data, was not re-initialized at the parsing of a dive during import from the divecomputer. So, in one import session, the po2 was transferred from one dive to the next, obviously resulting in weird bugs, due to possible wrong po2 settings. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Collaborator
Author
|
As this is something relevant for 4.6.4, I send this simple PR. Notice that this not resolves all my issues with OSTC3 setpoint handling (the default selected setpoint is not seen in Subsurface at the start of the dive; but this PR does not solve that, obviously). This fix might even resolve the intermittent failure of the TestParse. |
Collaborator
|
Thanks for sending this. Yes, definitely something we want in 4.6.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file static po2 value, used to set the setpoint data, was not re-initialized at the parsing of a dive during import from the divecomputer. So, in one import session, the po2 was transferred from one dive to the next, obviously resulting in weird bugs, due to possible wrong po2 settings.
Signed-off-by: Jan Mulder jlmulder@xs4all.nl