Skip to content

Correct BT detect for OSTC Sport#482

Merged
dirkhh merged 1 commit intosubsurface:masterfrom
janmulder:hw-sport-detect
Jul 15, 2017
Merged

Correct BT detect for OSTC Sport#482
dirkhh merged 1 commit intosubsurface:masterfrom
janmulder:hw-sport-detect

Conversation

@janmulder
Copy link
Copy Markdown
Collaborator

@janmulder janmulder commented Jul 13, 2017

Apparently, OSTC Sport has a BT name like OSTCs<space><serial>.

Small code addition to detect this properly. As long as we do not have an improved way of detection. Notice that most of the HWs use the same BT hardware, so simple detection on offered services will not work.

Signed-off-by: Jan Mulder jlmulder@xs4all.nl

Apparently, OSTC Sport has a BT name like OSTCs<space><serial>.

Small code addition to detect this properly. As long as we
do not have an improved way of detection. Notice that most of
the HWs use the same BT hardware, so simple detection on offered
services will not work.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
@dirkhh
Copy link
Copy Markdown
Collaborator

dirkhh commented Jul 13, 2017

The whole BT detection code is crap - we need to look at UUIDs
Worse, the user experience is just terrible right now - I urgently need to find the time to redesign this (unless someone beats me to it).
For both desktop and mobile, there should be three different ways to pick your dive computer:

a) last n (5? 3?) dive computers used. Including their address (port or BT/BLE). Not as drop down but as buttons, I guess
b) detected devices - but only if we are confident that it's a dive computer (this can be a drop down)
c) current vendor/product drop downs, except that on mobile we need to add the port selection which we have on desktop already: be able to pick a BT/BLE address to go with your choice of vendor/product (and then do NOT validate if the name for that BT/BLE address matches), or FTDI or other magic strings

@dirkhh dirkhh closed this Jul 13, 2017
@dirkhh dirkhh reopened this Jul 13, 2017
@dirkhh
Copy link
Copy Markdown
Collaborator

dirkhh commented Jul 13, 2017

oops, didn't want to close this, just comment on it. sorry. wrong button

@dirkhh dirkhh merged commit 9397dbb into subsurface:master Jul 15, 2017
@janmulder janmulder deleted the hw-sport-detect branch July 19, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants