map-widget: marker edit improvements#793
Merged
dirkhh merged 3 commits intosubsurface:masterfrom Nov 9, 2017
Merged
Conversation
When starting to edit a new dive location, create a marker at the current map center instead of zooming out and centering on the 0,0 coordinate. This will help (and speed up) a lot the edition, if the user needs to add numerous dive markers at a specific location close to each other. refs subsurface#754 Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
This patch allows updating the location of map markers while editing a dive site and updating the text in the LocationInformationWidget in real-time. Currently it is only possible to see the marker changes by clicking 'Apply'. The modification required the following changes: - add the MapWidget::updateCurrentDiveSiteCoordinatesToMap() slot and call it each time the GPS text updates - separate the updateCurrentDiveSiteCoordinates(FromMap/ToMap) logic by having the FromMap/ToMap suffix to method names - make MapWidgetHelper::updateCurrentDiveSiteCoordinatesToMap() call a new MapLocationModel::updateMapLocationCoordinates() method, which updates selected location coordinates and the model - add MapLocation::setCoordinateNoEmit() that does not emit a signal when updating a coordinate Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Collaborator
|
Can I ask you to add a patch # 3 that edits the ReleaseNotes? :-) |
Member
Author
|
@dirkhh sure |
Member
Author
|
hope i got the release notes right. |
Collaborator
Hehe, no you didn't. Look at the structure of the file. Your change should go below the Thanks for making my life easier! |
neolit123
force-pushed
the
marker-edit
branch
from
b2ef467 to
17de7af
Compare
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
neolit123
force-pushed
the
marker-edit
branch
from
17de7af to
47414fb
Compare
Member
Author
|
think i got it this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
PATCH1:
When starting to edit a new dive location, create
a marker at the current map center instead of zooming
out and centering on the 0,0 coordinate.
This will help (and speed up) a lot the edition,
if the user needs to add numerous dive markers
at a specific location close to each other.
PATCH2:
This patch allows updating the location of map markers
while editing a dive site and updating the text in the
LocationInformationWidget in real-time.
Currently it is only possible to see the marker changes by
clicking 'Apply'.
The modification required the following changes:
and call it each time the GPS text updates
by having the FromMap/ToMap suffix to method names
call a new MapLocationModel::updateMapLocationCoordinates()
method, which updates selected location coordinates and the model
a signal when updating a coordinate
Changes made:
see list above
Related issues:
Fixes #754
Additional information:
none
Mentions:
@dirkhh @janmulder @sfuchs79