Update README.md #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct mixup of port names
Update PortCopy.ino
ICON.ORD is set as 0 which denotes active driver rather than open-drain. Added extra unimplemented bit comment to avoid confusion around how the 7 used bits map to the byte.
Correct ICON Register init
* Add begin() method usual for Arduino driver libs and the supporting ctor. * Begin without address argument shall use the ctor provided address, not reset it. * Apply suggestions from code review Cascade from `begin` with I2C address argument to `begin` w/o argument, it's clearer than calling `init()` from both places. Co-authored-by: Bertrand Lemasle <blemasle@gmail.com> Co-authored-by: Bertrand Lemasle <blemasle@gmail.com>
* Add enumeration with pin values for digitalWrite etc * It is recommended not to use enum class if implicit cast to value is required. C++23 is said to provide a standard library helper, until then, for scoping, wrapping in a struct is recommended. Co-authored-by: Bertrand Lemasle <blemasle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.