Skip to content

Fix uninstaller payload resolution and logo handling #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperJMN merged 1 commit into from
Nov 22, 2025
Merged

Fix uninstaller payload resolution and logo handling #131

SuperJMN merged 1 commit into from
Nov 22, 2025

Conversation

@SuperJMN
Copy link
Owner

@SuperJMN SuperJMN commented Nov 22, 2025

Summary

  • store installer logo assets alongside metadata so the uninstaller can display branding when running from the install folder
  • surface disk-based metadata and logo payloads for uninstallers and hide the missing-installation message when a record exists
  • add coverage ensuring metadata payloads expose persisted logos

Testing

  • dotnet test (fails: DotnetPackaging.Msix.Tests missing TestFiles/ValidExe/Expected.msix)
  • dotnet test test/DotnetPackaging.Exe.Tests/DotnetPackaging.Exe.Tests.csproj -p:DisableParallelization=true

Codex Task

@SuperJMN SuperJMN merged commit 4c9dbfa into master Nov 22, 2025
1 check failed
@SuperJMN SuperJMN deleted the codex/fix-uninstallation-error-in-dotnetpackaging.tool branch November 22, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperJMN