Alternative approach to addressing #1282 #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passing on Python2 and Python3.
Contributor
Author
|
This should address #1282 - perhaps the reporter can confirm this? |
Closed
Contributor
Author
|
Hmmm - not sure yet about why the Travis jobs failed. Ran fine locally with |
… added to else case in asdict().
vsajip
changed the title
…rage.<machine-name>.NNNN.MMMM'.
Contributor
Author
|
@mnaberez do you need more feedback from others before merging this? Both the OP of #1282 (@Joppie) and @vaclavbartos have indicated that this change worked for them. |
Member
Nope, I'm going to run it locally and then merge it. Thank you! |
Member
|
I tested this on both Python 2 and 3 using the reproduce instructions and it worked on both. The exception does not occur and the message is logged to syslog. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing on Python2 and Python3.