XCAssets: add support for AR Resource Groups #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
djbe
changed the title
AliSoftware
requested changes
Feb 24, 2019
djbe
force-pushed
the
feature/rename-catalogs
branch
from
27a2767 to
73ded8b
Compare
djbe
force-pushed
the
feature/xcassets-ar-resource-group
branch
from
c30085f to
36f4129
Compare
djbe
changed the title
djbe
force-pushed
the
feature/xcassets-ar-resource-group
branch
5 times, most recently
from
645282a to
8914383
Compare
AliSoftware
reviewed
Mar 1, 2019
SwiftGen.playground/Pages/XCAssets-Demo.xcplaygroundpage/Sources/Implementation Details.swift
Show resolved
Hide resolved
djbe
force-pushed
the
feature/xcassets-ar-resource-group
branch
2 times, most recently
from
50b64b3 to
3cf638a
Compare
djbe
force-pushed
the
feature/xcassets-ar-resource-group
branch
from
3cf638a to
5545c90
Compare
…ers as deprecated
djbe
force-pushed
the
feature/xcassets-ar-resource-group
branch
from
5545c90 to
fbdc752
Compare
AliSoftware
reviewed
Mar 10, 2019
SwiftGen.playground/Pages/XCAssets-Demo.xcplaygroundpage/Contents.swift
Outdated
Show resolved
Hide resolved
AliSoftware
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for AR Resource Groups, which contain reference images and objects (hence the 2 accessors).
I'm going to work my way down the list of asset types we can support. This just happens to be the first one alphabetically (app icons don't count, we can't do anything with them).
Note:
based on #613, so merge that first.Note: I made sure the test resources are from the public domain, or made them myself (reference object).