Skip to content

Template lookupFunction parameter #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 9, 2020
Merged

Template lookupFunction parameter #738

merged 13 commits into from
Jul 9, 2020

Conversation

@djbe
Copy link
Member

@djbe djbe commented Jun 29, 2020 •
edited
Loading

As discussed in #716 (comment):

Adapt the lookupFunction parameter to other templates that support it: fonts, IB scenes, json, and plist.
For now, we won't adapt lookupFunction to the assets templates, as we'd need multiple lookup functions (one for each type).

Applies to:

  • Fonts
  • IB
  • JSON
  • Plist

@djbe djbe added this to the 6.3.0 milestone Jun 29, 2020
@SwiftGen-Eve
Copy link

SwiftGen-Eve commented Jun 29, 2020 •
edited
Loading

1 Warning
⚠️ Big PR

Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖

Thanks a lot for your contribution!

Seems like everything is in order 👍 You did a good job here! 🤝

Generated by 🚫 Danger

@djbe djbe force-pushed the feature/template-bundle-parameter branch from 4f68c61 to e4edd1d Compare June 29, 2020 00:59
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 6492153 to 2d55421 Compare June 29, 2020 00:59
@djbe djbe mentioned this pull request Jun 29, 2020
Merged
@djbe djbe force-pushed the feature/template-bundle-parameter branch from e4edd1d to 447a0e2 Compare July 5, 2020 14:42
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 2d55421 to e81b36b Compare July 5, 2020 14:43
@djbe djbe force-pushed the feature/template-bundle-parameter branch from 447a0e2 to c73b432 Compare July 5, 2020 15:21
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch 2 times, most recently from a29b318 to 1a5e5f2 Compare July 5, 2020 15:27
@djbe djbe force-pushed the feature/template-bundle-parameter branch from c73b432 to 626eeb5 Compare July 5, 2020 21:44
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 1a5e5f2 to c32d1d4 Compare July 5, 2020 21:44
@djbe djbe force-pushed the feature/template-bundle-parameter branch from 626eeb5 to 6a0e35e Compare July 6, 2020 11:18
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from c32d1d4 to 4e75867 Compare July 6, 2020 11:20
@djbe djbe force-pushed the feature/template-bundle-parameter branch from 6a0e35e to 8d45e1a Compare July 6, 2020 16:10
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 4e75867 to fae4a7e Compare July 6, 2020 16:12
@djbe djbe force-pushed the feature/template-bundle-parameter branch from 8d45e1a to 332a801 Compare July 6, 2020 18:33
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from fae4a7e to 78ff2ee Compare July 6, 2020 18:34
@djbe djbe force-pushed the feature/template-bundle-parameter branch from 332a801 to fac8315 Compare July 6, 2020 21:26
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 78ff2ee to 9a9c42d Compare July 6, 2020 21:28
@djbe djbe force-pushed the feature/template-bundle-parameter branch from fac8315 to 85132c4 Compare July 7, 2020 23:12
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch 2 times, most recently from ac0ebe2 to efc3fc9 Compare July 7, 2020 23:21
Base automatically changed from feature/template-bundle-parameter to develop July 7, 2020 23:48
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from efc3fc9 to 425ccff Compare July 7, 2020 23:49
@djbe djbe marked this pull request as ready for review July 7, 2020 23:50
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 425ccff to fbcd225 Compare July 8, 2020 00:14
@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from ed317be to df0daa4 Compare July 8, 2020 00:40
AliSoftware
AliSoftware reviewed Jul 8, 2020
View reviewed changes
AliSoftware
AliSoftware reviewed Jul 8, 2020
View reviewed changes
AliSoftware
AliSoftware reviewed Jul 8, 2020
View reviewed changes
@AliSoftware AliSoftware force-pushed the feature/template-lookupfunction-parameter branch 3 times, most recently from eadfa52 to db197f6 Compare July 9, 2020 18:39
@AliSoftware AliSoftware force-pushed the feature/template-lookupfunction-parameter branch from db197f6 to 4e17796 Compare July 9, 2020 19:21
AliSoftware
AliSoftware reviewed Jul 9, 2020
View reviewed changes
AliSoftware
AliSoftware reviewed Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry got interrupted and didn't finish the changes, thanks for following up. Will read all that after dinner

@djbe djbe force-pushed the feature/template-lookupfunction-parameter branch from 72d4e2a to 3747409 Compare July 9, 2020 20:33
AliSoftware
AliSoftware reviewed Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nitpicks

AliSoftware
AliSoftware reviewed Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final touch/nitpicks, but then we should be good to go 🙂

@AliSoftware AliSoftware merged commit 88d086b into develop Jul 9, 2020
@AliSoftware AliSoftware deleted the feature/template-lookupfunction-parameter branch July 9, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

6.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@djbe @SwiftGen-Eve @AliSoftware