Modernize snapshots #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
melle
commented
Nov 4, 2024
melle
commented
- Drop iPhone SE 1 (breaking change!), switch default phone devices to 13pro+13proMax
- adopt new SnapshotTesting API
Collaborator
Author
|
The plan is to release this with a new major version because of the breaking change. |
OguzYuuksel
reviewed
Nov 4, 2024
- Drop iPhone SE 1 (breaking change!), switch default phone devices to iphone8 (4.7”) + 13proMax (6.7”) - adopt new SnapshotTesting API
melle
force-pushed
the
modernize-snapshots
branch
from
7af0018 to
164468f
Compare
OguzYuuksel
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.