Skip to content

Conversation

@hstdt
Copy link
Contributor

@hstdt hstdt commented May 30, 2024

Fix this situation:

@Codable
    struct SomeCodable {
        let value: String!
}

CleanShot 2024-05-30 at 20 22 52

@soumyamahunt
Copy link
Contributor

@hstdt nice catch, please add a test case asserting the behaviour as well.

@hstdt
Copy link
Contributor Author

hstdt commented May 31, 2024

commit above fixed error with@Default macro

image

@hstdt
Copy link
Contributor Author

hstdt commented May 31, 2024

@soumyamahunt tests added.

if the last commit of tests is not necessary, i'll revert it.

@hstdt
Copy link
Contributor Author

hstdt commented May 31, 2024

PS:
The expanded code of testWithNestedPathOnMixedTypes() and testClassWithNestedPathOnMixedTypes() in CodedInDefaultTests is not compilable(not related to this pull request): "Return from initializer without initializing all stored properties"

@soumyamahunt
Copy link
Contributor

PS: The expanded code of testWithNestedPathOnMixedTypes() and testClassWithNestedPathOnMixedTypes() in CodedInDefaultTests is not compilable(not related to this pull request): "Return from initializer without initializing all stored properties"

Thanks for reporting this, this has been fixed. Please rebase your branch and update test cases if needed.

@hstdt hstdt force-pushed the implicitly_unwrapped branch from 051bfb1 to 703ea04 Compare June 7, 2024 02:52
@hstdt
Copy link
Contributor Author

hstdt commented Jun 7, 2024

@soumyamahunt updated

Copy link
Contributor

@soumyamahunt soumyamahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hstdt changes LGTM, anything else you would like to add or should I merge this?

@hstdt
Copy link
Contributor Author

hstdt commented Jun 7, 2024

@soumyamahunt Nothing else to add. Please merge it.

@soumyamahunt soumyamahunt merged commit 29b9f00 into SwiftyLab:main Jun 7, 2024
@hstdt hstdt deleted the implicitly_unwrapped branch June 7, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants