-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat: support implicitly unwrapped optional type #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hstdt nice catch, please add a test case asserting the behaviour as well. |
|
@soumyamahunt tests added. if the last commit of tests is not necessary, i'll revert it. |
|
PS: |
Thanks for reporting this, this has been fixed. Please rebase your branch and update test cases if needed. |
Sources/PluginCore/Variables/Property/BasicPropertyVariable.swift
Outdated
Show resolved
Hide resolved
051bfb1 to
703ea04
Compare
|
@soumyamahunt updated |
soumyamahunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hstdt changes LGTM, anything else you would like to add or should I merge this?
|
@soumyamahunt Nothing else to add. Please merge it. |

Fix this situation: