Skip to content

Conversation

@brian428
Copy link

Since it doesn't look like a pull request was made for this yet, I figured I'd do it.

@brian428 brian428 changed the title Re: #544 - Add logic to include manually-defined TSDs in TSD query. fixes #544 - Add logic to include manually-defined TSDs in TSD query. Jun 25, 2015
@Swiip
Copy link
Owner

Swiip commented Jul 14, 2015

Sorry for the huuuge delay. I have verified that it keep working but could you give me an example for using it? Like a lib to add in the TSD file?

@brian428
Copy link
Author

I'm doing something like this. In this example, the Bower dep. is named "jasmine-core", but the TSD itself is named just "jasmine". Meaning the default TSD lookup using the Bower name won't find the TSD (or at least it wasn't for me). So this this patch, the build should look for my local copy of jasmine.d.ts and include that in the build's typings.

{
  "version": "v4",
  "repo": "borisyankov/DefinitelyTyped",
  "ref": "master",
  "path": ".tmp/typings",
  "bundle": ".tmp/typings/tsd.d.ts",
  "installed": {
      "src/tsd/libs/jasmine/jasmine.d.ts": { 
        "commit": "dd6c0bef0e3714a9f4bb969e7b823eda81a35dc4" 
      }
  }
}

@zckrs
Copy link
Collaborator

zckrs commented Aug 28, 2015

I checkout your branch and test gulp tsd that don't fix issue. :/

@zckrs zckrs closed this Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants