Fix inject script for jsPrepro #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I was considering that when you choose Coffee for example you can still have JS sources, both will work. The change that you make will break this. What was the problem with the original conf? |
Collaborator
Author
|
The orignal problem is we inject spec.js in the Mixed Coffee and JS is a common case in project ? |
Owner
|
Yep, at least it "was" |
Owner
|
Is it not possible to keep the possibility excluding the |
added 2 commits
July 2, 2015 11:50
* plain JS: inject files in `src` folder and exclude `*.spec.js` * Coffescript: inject generate JS files in `.tmp` folder and exclude `*.spec.js` && inject plain JS files in `src` and exclude `*.spec.js` * ES6/TS: inject only `index.module.js` present in `.tmp` folder
Collaborator
Author
|
Done |
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
injectScript only depend if jsPrepro is used
If jsPrepro we use the .tmp folder