Switch from jshint to eslint inside the generator

.eslintignore

@@ -0,0 +1,3 @@
+node_modules/
+app/templates/
+test/tmp/

.eslintrc

@@ -0,0 +1,9 @@
+{
+  "rules": {
+    "strict": [2, "global"],
+    "quotes": [2, "single"]
+  },
+  "env": {
+    "node": true
+  }
+}

.gitignore

@@ -5,4 +5,3 @@ npm-debug.log
 .idea
 *.iml
 test/tmp
-.jshintignore

app/src/mock-options.js

@@ -4,7 +4,7 @@
  *
  * This module gets default yo options from options.json into a hash
  * to be reused in tests and other places that requires default options
- * 
+ *
  */
 
 var options = require('../options.json');

app/src/prompts.js

@@ -19,20 +19,20 @@ module.exports = function(GulpAngularGenerator) {
    * Check if the default option is set, if it is, use defaults props and log them
    */
   GulpAngularGenerator.prototype.defaultOption = function defaultOption() {
-    if (this.options['default']) {
+    if (this.options.default) {
       this.props = _.merge(this.props, mockPrompts.defaults);
 
       this.log('__________________________');
       this.log('You use ' + chalk.green('--default') + ' option:');
 
-      _.forEach(this.props, function(prop, key) {
+      _.forEach(this.props, function(propOrProps, key) {
         var prompt = _.find(prompts, {name: key});
-        if(_.isArray(prop)) {
-          prop.forEach(function(prop) {
+        if(_.isArray(propOrProps)) {
+          propOrProps.forEach(function(prop) {
             logChoice.call(this, prompt, prop);
           }, this);
         } else {
-          logChoice.call(this, prompt, prop);
+          logChoice.call(this, prompt, propOrProps);
         }
       }, this);
 
@@ -46,12 +46,12 @@ module.exports = function(GulpAngularGenerator) {
   GulpAngularGenerator.prototype.checkYoRc = function checkYoRc() {
     var done = this.async();
 
-    if(this.config.get('props') && !this.options['default']) {
+    if(this.config.get('props') && !this.options.default) {
       this.prompt([{
         type: 'confirm',
         name: 'skipConfig',
         message: 'Existing ' + chalk.green('.yo-rc') + ' configuration found, would you like to use it?',
-        default: true,
+        default: true
       }], function (answers) {
         this.skipConfig = answers.skipConfig;
 
@@ -73,7 +73,7 @@ module.exports = function(GulpAngularGenerator) {
    * Complete responses with null answers for questions not asked
    */
   GulpAngularGenerator.prototype.askQuestions = function askQuestions() {
-    if (this.skipConfig || this.options['default']) {
+    if (this.skipConfig || this.options.default) {
       return;
     }
 
@@ -121,7 +121,7 @@ module.exports = function(GulpAngularGenerator) {
     this.qrCode = false;
 
     if (this.skipConfig || !this.options.advanced) {
-      return ;
+      return;
     }
 
     var done = this.async();

app/src/techs.js

@@ -37,7 +37,7 @@ module.exports = function(GulpAngularGenerator) {
       .replace(/\n/g, '\n    ');
 
     usedTechs.forEach(function(value) {
-      var path ='src/assets/images/' + listTechs[value].logo;
+      var path = 'src/assets/images/' + listTechs[value].logo;
 
       this.files.push({
         src: path,

app/src/write.js

@@ -2,8 +2,6 @@
 
 var utils = require('./utils');
 
-var _ = require('lodash');
-
 module.exports = function(GulpAngularGenerator) {
 
   /**

package.json

@@ -37,6 +37,7 @@
     "coveralls": "~2.11.2",
     "cross-spawn": "~0.4.1",
     "ejs": "~2.3.1",
+    "eslint": "^0.24.0",
     "fixture-stdout": "~0.2.1",
     "istanbul": "~0.3.15",
     "js-beautify": "~1.5.6",

test/.eslintrc

@@ -0,0 +1,8 @@
+{
+  "rules": {
+    "no-unused-expressions": 0
+  },
+  "env": {
+    "mocha": true
+  }
+}

test/inception/test-inception.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var inception = require('../inception');
 

test/mute.js

@@ -20,13 +20,13 @@ var fixtureErr = new Fixture({
   stream: process.stderr
 });
 
-var _writesOut = [];
-var _writesErr = [];
+var writesOut = [];
+var writesErr = [];
 
 // Mute
 module.exports.mute = function () {
   fixtureOut.capture(function onWrite(string) {
-    _writesOut.push({
+    writesOut.push({
       string: string
     });
 
@@ -36,7 +36,7 @@ module.exports.mute = function () {
 
 
   fixtureErr.capture(function onWrite(string) {
-    _writesErr.push({
+    writesErr.push({
       string: string
     });
 
@@ -54,7 +54,7 @@ module.exports.unmute = function () {
 // Return the output that was captured
 module.exports.getMutedWrites = function () {
   return {
-    out: _writesOut,
-    err: _writesErr
+    out: writesOut,
+    err: writesErr
   };
 };

test/node/mock-generator.js

@@ -3,7 +3,7 @@
 require('yeoman-generator');
 var _ = require('lodash');
 
-module.exports = function() {
+module.exports = function() {
   this._ = _;
   this.log = function() {};
   this.async = function() {

test/node/test-files.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');

test/node/test-index.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');

test/node/test-modules.js

@@ -1,14 +1,10 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
-var sinon = require('sinon');
 var sinonChai = require('sinon-chai');
 chai.should();
 chai.use(sinonChai);
 
-var _ = require('lodash');
-
 var Generator = require('./mock-generator');
 var generator;
 
@@ -34,7 +30,7 @@ describe('gulp-angular generator modules script', function () {
       router: { module: 'testModule1' },
       ui: { module: 'testModule2' },
       bootstrapComponents: { module: 'testModule3' },
-      foundationComponents: { module: 'testModule4' },
+      foundationComponents: { module: 'testModule4' }
     };
     generator.computeModules();
     generator.modulesDependencies.should.match(/\', \'/);

test/node/test-paths.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');

test/node/test-preprocessors.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinonChai = require('sinon-chai');

test/node/test-prompts.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');
@@ -36,7 +35,7 @@ describe('gulp-angular generator prompts script', function () {
 
     it('should use default props if option is set', function() {
       sinon.spy(generator, 'log');
-      generator.options['default'] = true;
+      generator.options.default = true;
       generator.defaultOption();
       generator.props.should.be.deep.equal(mockPrompts.defaults);
       var logLines = 3 + _.flatten(_.values(generator.props)).length;

test/node/test-router.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');

test/node/test-techs.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinonChai = require('sinon-chai');
@@ -35,8 +34,8 @@ describe('gulp-angular generator techs script', function () {
       ui: { key: 'tech-name-2' },
       bootstrapComponents: { key: null },
       foundationComponents: { key: 'none' },
-      cssPreprocessor: { extension: 'default' },
-      jsPreprocessor: { extension: 'css' },
+      cssPreprocessor: { extension: 'default' },
+      jsPreprocessor: { extension: 'css' },
       htmlPreprocessor: { extension: 'official' }
     };
     generator.files = [];

test/node/test-ui.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 chai.should();
@@ -24,7 +23,7 @@ describe('gulp-angular generator ui script', function () {
       generator.props = {
         router: { module: null },
         ui: { key: 'none' },
-        cssPreprocessor: { key: 'none', extension: 'css' }
+        cssPreprocessor: { key: 'none', extension: 'css' }
       };
       generator.files = [];
       generator.uiFiles();
@@ -39,7 +38,7 @@ describe('gulp-angular generator ui script', function () {
       generator.props = {
         router: { module: 'ngRoute' },
         ui: { key: 'bootstrap' },
-        cssPreprocessor: { key: 'notnone', extension: 'scss' }
+        cssPreprocessor: { key: 'notnone', extension: 'scss' }
       };
       generator.files = [];
       generator.uiFiles();
@@ -58,7 +57,7 @@ describe('gulp-angular generator ui script', function () {
         jQuery: { key: 'jquery1' },
         ui: { key: 'bootstrap' },
         bootstrapComponents: { key: 'angular-bootstrap' },
-        cssPreprocessor: { extension: 'scss' }
+        cssPreprocessor: { extension: 'scss' }
       };
       generator.computeWiredepExclusions();
       generator.wiredepExclusions[0].should.be.equal('/bootstrap\.js$/');
@@ -71,7 +70,7 @@ describe('gulp-angular generator ui script', function () {
         jQuery: { key: 'jquery1' },
         ui: { key: 'bootstrap' },
         bootstrapComponents: { key: 'angular-bootstrap' },
-        cssPreprocessor: { extension: 'less' }
+        cssPreprocessor: { extension: 'less' }
       };
       generator.computeWiredepExclusions();
       generator.wiredepExclusions[0].should.be.equal('/bootstrap\.js$/');
@@ -83,7 +82,7 @@ describe('gulp-angular generator ui script', function () {
         jQuery: { key: 'jquery1' },
         ui: { key: 'foundation' },
         foundationComponents: { key: 'angular-foundation' },
-        cssPreprocessor: { extension: 'scss' }
+        cssPreprocessor: { extension: 'scss' }
       };
       generator.computeWiredepExclusions();
       generator.wiredepExclusions[0].should.be.equal('/foundation\\.js/');
@@ -95,7 +94,7 @@ describe('gulp-angular generator ui script', function () {
         jQuery: { key: 'jquery1' },
         ui: { key: 'foundation' },
         foundationComponents: { key: 'angular-foundation' },
-        cssPreprocessor: { extension: 'notscss' }
+        cssPreprocessor: { extension: 'notscss' }
       };
       generator.computeWiredepExclusions();
       generator.wiredepExclusions[0].should.be.equal('/foundation\\.js/');

test/node/test-writes.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinon = require('sinon');

test/template-tools.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint camelcase:false */
 
 var fs = require('mz/fs');
 var Promise = require('bluebird');
@@ -46,7 +45,7 @@ function compile(fileName) {
     fs.readFile(sourceFilePath)
   ]).then(function(results) {
     var content = results[1].toString();
-    var sourceContent = sourceHeader + beautify(compileEjs(content), { indent_size: 2 }) + sourceFooter;
+    var sourceContent = sourceHeader + beautify(compileEjs(content), { 'indent_size': 2 }) + sourceFooter;
     sourceContent = sourceContent.replace('with(locals || {})', 'with(locals)');
     return fs.writeFile(destinationFilePath, sourceContent);
   });

test/template/mock-model.js

@@ -4,7 +4,7 @@ require('yeoman-generator');
 var _ = require('lodash');
 var mockPrompts = require('../../app/src/mock-prompts');
 
-module.exports = function() {
+module.exports = function() {
   var props = _.extend(_.cloneDeep(mockPrompts.defaults), {
     paths: {
       src: null,

test/template/test-bower.js

@@ -1,5 +1,4 @@
 'use strict';
-/* jshint expr:true */
 
 var chai = require('chai');
 var sinonChai = require('sinon-chai');