Skip to content

Conversation

@Swiip
Copy link
Owner

@Swiip Swiip commented Jul 9, 2015

By computing them before templating.

Yep, I know, I have to fix tests, and I should write tests while coding...

@Swiip
Copy link
Owner Author

Swiip commented Jul 11, 2015

Tests done.

I moved wiredep exclusions computing in a new src/bower.js file to unite specific bower computing.

@zckrs
Copy link
Collaborator

zckrs commented Jul 12, 2015

👍
Nice work but can you rebase on master ?
And why you write this PR ? Bug, improvement ?

@Swiip
Copy link
Owner Author

Swiip commented Jul 12, 2015

You're right, I forgot to explain evil plan for the conquest of the universe.

First of all, it should fix #644 and fix #637 as this code overrides fonts links in the main of bootstrap's bower file.

But more important, I'm working on the angular new router feature and it requires also a bower overrides and I needed this to do it correctly.

@Swiip Swiip force-pushed the organize-bower-overrides branch from 36b66af to 8440533 Compare July 12, 2015 08:07
zckrs pushed a commit that referenced this pull request Jul 13, 2015
@zckrs zckrs merged commit 6e55985 into master Jul 13, 2015
@loren138
Copy link

Any thoughts on the next release? Trying to decide the best way to get bootstrap fonts working for my code...

@Swiip Swiip deleted the organize-bower-overrides branch September 9, 2015 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants