Skip to content

Conversation

@e-oz
Copy link

@e-oz e-oz commented Aug 2, 2015

npm module gulp-filter version 3.0 has backward-incompatible changes, this commit fixing it

@e-oz
Copy link
Author

e-oz commented Aug 2, 2015

tests failure is not related to this commit.

@Swiip
Copy link
Owner

Swiip commented Aug 6, 2015

It's our shrinkwrap mechanism which prevent updating the dependencies.

Could you:

node test/template-cli deps
cd test/tmp/deps
rm -rf node_modules
npm install
npm shrinkwrap
cp npm-shrinkwrap.json ../..

And commit the file? We should definitely write doc about that... and make a script...

@e-oz
Copy link
Author

e-oz commented Aug 6, 2015

I did it, tests are failed again because of dependencies.
Changes in this commit are pretty simple, easy to observe. Feel free to decline pr, my aim was just to warn you about critical changes in gulp-filter.

@Swiip
Copy link
Owner

Swiip commented Aug 6, 2015

This failure is actually a real one. You successed fixing the shrinkwrap thing but there is a use of gulp filter you miss: https://github.com/Swiip/generator-gulp-angular/blob/master/app/templates/gulp/_styles.js#L68

@e-oz
Copy link
Author

e-oz commented Aug 6, 2015

Really, my fault, sorry.
Thanks for checking it.

@Swiip
Copy link
Owner

Swiip commented Aug 6, 2015

Yet another problem, doesn't understand this one...

@Swiip Swiip closed this Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants