Skip to content

Conversation

@bcldvd
Copy link

@bcldvd bcldvd commented Aug 17, 2015

First thing I wanted to do after generating my app with this generator was to change the port :/
I thought I'd add it for others like me :)

@Swiip
Copy link
Owner

Swiip commented Aug 18, 2015

As said here https://github.com/Swiip/generator-gulp-angular/blob/master/docs/how-it-works.md#gulpconfjs, we are very thrifty about the conf.js file as we don't want to come back to a big json file like with Grunt.

I don't see why it's needed to deport this conf from server.js to conf.js. It can be kept in server.js.

What we can do is to have better doc about configuring BS. If you turn your PR into a doc update, it would be highly appreciated.

@bcldvd
Copy link
Author

bcldvd commented Aug 18, 2015

Changed it into a doc update :)

@Swiip
Copy link
Owner

Swiip commented Aug 18, 2015

Thanks :) Would it be to much to ask if you could turn this into something a little more generic about "all" BS options including a link to http://www.browsersync.io/docs/options/ ?

@zckrs
Copy link
Collaborator

zckrs commented Aug 24, 2015

👍

@zckrs zckrs changed the title Allow port change and configuration in conf.js Doc: port change with Browser-Sync Aug 28, 2015
zckrs pushed a commit that referenced this pull request Aug 28, 2015
Doc: port change with Browser-Sync
@zckrs zckrs merged commit 5d491e6 into Swiip:master Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants