feat: Adds Github actions for integration tests and fixes macos and integration tests (#762)

* Adds github action for integration tests

* Increases file handles for OSX

* Make homebrew verbose to hopefully help prevent timeouts

* Bump version of tested osx

Author: Panaetius

.github/workflows/integration_tests.yml

@@ -0,0 +1,51 @@
+name: CI-integration-tests
+
+on:
+  push:
+    branches:
+      - master
+
+jobs:
+  test-linux-integration:
+    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.6, 3.7]
+    steps:
+    - uses: actions/checkout@master
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install -e .[nodocs]
+        git config --global --add user.name "Renku @ SDSC"
+        git config --global --add user.email "renku@datascience.ch"
+    - name: Test with pytest
+      run: pytest -m integration -v
+
+  test-macos-integration:
+    runs-on: macos-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.6, 3.7]
+    steps:
+    - uses: actions/checkout@master
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        brew update
+        brew install git-lfs shellcheck node || brew link --overwrite node
+        python -m pip install --upgrade pip
+        python -m pip install -e .[all]
+        git config --global --add user.name "Renku @ SDSC"
+        git config --global --add user.email "renku@datascience.ch"
+    - name: Test with pytest
+      run: pytest -m integration -v

.travis.yml

@@ -69,12 +69,13 @@ before_install:
         requirements-builder -e nodocs --level=pypi setup.py > .travis-release-requirements-nodocs.txt;
         requirements-builder -e nodocs --level=dev --req requirements-devel.txt setup.py > .travis-devel-requirements-nodocs.txt;
     elif [[ $TRAVIS_OS_NAME == 'osx' ]]; then
+        ulimit -n 1024;
         brew update;
-        brew upgrade python;
+        brew upgrade -v python;
         brew unlink python;
         brew link python;
-        brew install git-lfs jq node pipenv shellcheck;
-        brew upgrade node;
+        brew install -v git-lfs jq node pipenv shellcheck;
+        travis_wait brew upgrade node;
     fi
 
 install:
@@ -153,15 +154,15 @@ jobs:
         - REQUIREMENTS=lowest
       script: pytest -m integration -v
     - stage: test OSX
-      if: branch = master
       language: generic
       sudo: true
       os: osx
-      osx_image: xcode10.1
-    - language: generic
+      osx_image: xcode11.2
+    - stage: test OSX
+      language: generic
       sudo: true
       os: osx
-      osx_image: xcode9.2
+      osx_image: xcode10.1
 
     - stage: publish 🐍
       python: 3.6
@@ -191,8 +192,8 @@ jobs:
       language: generic
       sudo: true
       os: osx
-      osx_image: xcode10.2
-      before_install: brew install jq
+      osx_image: xcode11.2
+      before_install: brew -v install jq
       install: python -m pip install requests
       script:
         - echo PY_BREW_VERSION=$(python setup.py --version)

conftest.py

@@ -465,3 +465,14 @@ def doi_dataset():
         dataset_yaml = f.read()
 
     return dataset_yaml
+
+
+@pytest.fixture()
+def sleep_after():
+    """Fixture that causes a delay after executing a test.
+
+    Prevents spamming external providers when used, in case of rate limits.
+    """
+    import time
+    yield
+    time.sleep(0.5)

tests/cli/test_integration_datasets.py

@@ -40,7 +40,7 @@
     }]
 )
 @pytest.mark.integration
-def test_dataset_import_real_doi(runner, project, doi):
+def test_dataset_import_real_doi(runner, project, doi, sleep_after):
     """Test dataset import for existing DOI."""
     result = runner.invoke(
         cli, ['dataset', 'import', doi['doi']], input=doi['input']
@@ -88,7 +88,7 @@ def test_dataset_import_real_doi(runner, project, doi):
     ]
 )
 @pytest.mark.integration
-def test_dataset_import_real_param(doi, runner, project):
+def test_dataset_import_real_param(doi, runner, project, sleep_after):
     """Test dataset import and check metadata parsing."""
     result = runner.invoke(cli, ['dataset', 'import', doi[0]], input=doi[1])
 
@@ -110,7 +110,7 @@ def test_dataset_import_real_param(doi, runner, project):
     ]
 )
 @pytest.mark.integration
-def test_dataset_import_uri_404(doi, runner, project):
+def test_dataset_import_uri_404(doi, runner, project, sleep_after):
     """Test dataset import and check that correct exception is raised."""
     result = runner.invoke(cli, ['dataset', 'import', doi[0]], input=doi[1])
     assert 2 == result.exit_code
@@ -120,7 +120,7 @@ def test_dataset_import_uri_404(doi, runner, project):
 
 
 @pytest.mark.integration
-def test_dataset_import_real_doi_warnings(runner, project):
+def test_dataset_import_real_doi_warnings(runner, project, sleep_after):
     """Test dataset import for existing DOI and dataset"""
     result = runner.invoke(
         cli, ['dataset', 'import', '10.5281/zenodo.1438326'], input='y'
@@ -176,7 +176,7 @@ def test_dataset_import_fake_doi(runner, project, doi):
     ]
 )
 @pytest.mark.integration
-def test_dataset_import_real_http(runner, project, url):
+def test_dataset_import_real_http(runner, project, url, sleep_after):
     """Test dataset import through HTTPS."""
     result = runner.invoke(cli, ['dataset', 'import', url], input='y')