Publish SHACL to repo #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/renku-python into 755-kg-validation
…/renku-python into 755-kg-validation
Contributor
|
I see. But that ability should probably be part of the schema versioning itself since we gonna most likely need it inside the core module for migrations. Also, having a new directory for every changed schema version (vs. for every commit) makes it easier/possible to track changes of schema through time (I think the same wouldn't be the case after 200 commits on master with current setup). I guess there is a tradeoff for both. |
Member
Author
|
i changed it so it only gets executed when |
jsam
previously approved these changes
Nov 15, 2019
Contributor
jsam
left a comment
jsam
left a comment
There was a problem hiding this comment.
Thank you for setting this up. It's pretty cool!
rokroskar
reviewed
Nov 15, 2019
rokroskar
previously approved these changes
Nov 15, 2019
* Adds SHACL validation to renku doctor * Adds renku log tests * Adds --strict option to renku log for shape validation
rokroskar
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github action to copy the
shacl_shape.jsonto a different repository on commit to master with version.Currently configured to go to https://github.com/Panaetius/SHACL_test_repo for testing.
Access Token needs to be generated for this with rights to the final repository where the SHACL should end up in. Until then it's WIP and it pushes to the test repo on every commit (not just on commit to master)
Closes SwissDataScienceCenter/renku#685