Skip to content

notebook: fix encoding during save #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2017
Merged

notebook: fix encoding during save #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion renga/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,9 @@ def _save_notebook(self, path, nb):
file_ = self._resolve_path(path)._obj

with file_.open('w') as fp:
fp.write(nbformat.writes(nb, version=nbformat.NO_CONVERT))
fp.write(
nbformat.writes(nb, version=nbformat.NO_CONVERT).encode(
'utf-8'))

def _resolve_path(self, path):
"""Return a resource based on the specified path."""
Expand Down