Skip to content

Conversation

@Panaetius
Copy link
Member

Adds a github action to enforce that PR titles conform to conventional commits syntax

@Panaetius Panaetius requested a review from a team as a code owner December 3, 2019 08:29
@Panaetius Panaetius changed the title Adds semantic PR github action chore: Adds semantic PR github action Dec 3, 2019
@Panaetius
Copy link
Member Author

Currently, the action is triggered when the title is changed, but due to how Github handles actions, a previously failed check persists unless there's a new commit. In this case the failing action needs to be rerun to get it to pass. I don't see a way around this

Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you.

@Panaetius Panaetius merged commit 0b60ec8 into master Dec 3, 2019
@Panaetius Panaetius deleted the semantic-pr-action branch December 3, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants