Skip to content

feat: use project name as default path when cloning #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2019
Merged

feat: use project name as default path when cloning #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f69f7ec
feat: use project name as default path when cloning
mohammad-alisafaee Dec 11, 2019
789d05e
Merge branch 'master' into 856-use-project-name-as-default-path-in-clone
mohammad-alisafaee Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion renku/core/management/clone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

from renku.core import errors
from renku.core.management.githooks import install
from renku.core.models.git import GitURL


def clone(
Expand All @@ -38,7 +39,7 @@ def clone(
"""Clone Renku project repo, install Git hooks and LFS."""
from renku.core.management.client import LocalClient

path = path or '.'
path = path or GitURL.parse(url).name
# Clone the project
if skip_smudge:
os.environ['GIT_LFS_SKIP_SMUDGE'] = '1'
Expand Down
17 changes: 17 additions & 0 deletions tests/cli/test_integration_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,3 +927,20 @@ def test_renku_clone(runner, monkeypatch):
result = runner.invoke(cli, ['run', 'touch', 'output'])
assert 'is not configured' in result.output
assert 1 == result.exit_code


@pytest.mark.integration
@pytest.mark.parametrize(
'path,expected_path', [('', 'datasets-test'), ('.', '.'),
('new-name', 'new-name')]
)
def test_renku_clone_uses_project_name(
runner, monkeypatch, path, expected_path
):
"""Test renku clone uses project name as target-path by default."""
REMOTE = 'https://dev.renku.ch/gitlab/virginiafriedrich/datasets-test.git'

with runner.isolated_filesystem() as project_path:
result = runner.invoke(cli, ['clone', REMOTE, path])
assert 0 == result.exit_code
assert (Path(project_path) / expected_path / 'Dockerfile').exists()