feat: add optional commit message #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renku/core/management/git.py
Outdated
|
|
||
| argv = [os.path.basename(sys.argv[0]) | ||
| ] + [remove_credentials(arg) for arg in sys.argv[1:]] | ||
| if commit_message is None or not isinstance(commit_message, str): |
Contributor
There was a problem hiding this comment.
It's good to check for the empty message as well. Also, for the case of non-string message, I'd rather raise an exception or just use str(commit_message) to make it visible instead of silently ignoring it. Since we are the user of this API, str(commit_message) would be enough.
rokroskar
reviewed
Dec 12, 2019
Member
rokroskar
left a comment
rokroskar
left a comment
There was a problem hiding this comment.
This is going to be a nice improvement, but why limit it to the dataset commands?
jsam
changed the title
Contributor
Author
I've added now explicit params to all other commands. |
…nku-python into 768_commit_msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #768