Ios fix missing method exception #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 4, 2019 14:31
- Set TLSMinimumSupportedProtocol based on ServicePointManager.SecurityProtocol on iOS
…meter, NSUrlSessionDelegate parameter is obsolete
dationguyen
approved these changes
Apr 4, 2019
pperera
reviewed
Apr 5, 2019
Makefile
Outdated
| package: ModernHttpClient.iOS64.dll ModernHttpClient.Android.dll ModernHttpClient.Portable.dll | ||
| nuget pack | ||
| mv modernhttpclient*.nupkg ./build/ | ||
| mv modernhttpclient*.nupkg ~/.local/share/NuGet/Cache/ |
There was a problem hiding this comment.
should leave this as ./build/
Suggested change
| mv modernhttpclient*.nupkg ~/.local/share/NuGet/Cache/ | |
| mv modernhttpclient*.nupkg ./build/ |
pperera
reviewed
Apr 5, 2019
Makefile
Outdated
| $(MDTOOL) build -t:Clean ModernHttpClient.sln | ||
| rm *.dll | ||
| rm -rf build | ||
|
|
There was a problem hiding this comment.
great helper method, I don't think makefile should have dependancies on things like xmlstarlet
There was a problem hiding this comment.
I've removed the version-bump target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed minimumSSLProtocol parameter from NSUrlSessionHandler constructor
Set TLSMinimumSupportedProtocol on iOS based on SecurityProtocolType
Fix 'NSUrlSession.FromConfiguration(NSUrlSessionConfiguration, NSUrlSessionDelegate, NSOperationQueue)' is obsolete warning
Update makefile to store nuget packages in ~/.local/share/NuGet/Cache folder