Add environment variable support for backend URL and remove hardcoded DNS #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Copilot wants to merge 4 commits into release from copilot/add-env-variable-support

.env.example

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    # SynBioHub Frontend Backend URL Configuration
+    # Uncomment and set this variable to override the default backend URL
+    # Default: http://localhost:7777
+    #SYNBIOHUB_BACKEND=http://localhost:7777

.gitignore

README.md

-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,22 @@ To run the base configuration: @@
 . `git clone -b snapshot https://github.com/synbiohub/synbiohub2-docker`
 . `docker-compose -f ./synbiohub2-docker/docker-compose.yml up`
+    ### Configuration
+    #### Backend URL
+    The frontend backend URL can be configured using the `SYNBIOHUB_BACKEND` environment variable. If not set, it defaults to `http://localhost:7777`.
+    To use a custom backend URL:
+    ```bash
+    SYNBIOHUB_BACKEND=http://your-backend-url:port docker-compose -f ./synbiohub2-docker/docker-compose.yml up
+    ```
+    Alternatively, you can create a `.env` file in the same directory as `docker-compose.yml`:
+    ```bash
+    cp .env.example .env
+    # Edit .env and uncomment/set SYNBIOHUB_BACKEND
+    docker-compose -f ./synbiohub2-docker/docker-compose.yml up
+    ```
     ### With Explorer
     To add [SBOLExplorer](https://github.com/michael13162/SBOLExplorer), add the `docker-compose.explorer.yml` to the main docker-compose, i.e. for step 3 run `docker-compose -f ./synbiohub2-docker/docker-compose.yml -f ./synbiohub2-docker/docker-compose.explorer.yml up`
@@ Expand Down @@

docker-compose.explorer.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -10,7 +10,6 @@ services: @@
                 - elasticsearch
                 - synbiohub
                 - synbiohubFrontend
-            dns: 8.8.8.8
             volumes:
                 - type: volume
                   source: explorer
@@ Expand Down @@

docker-compose.pluginDownloadTest.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-download-test:snapshot
             ports:
                 - "8089:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginDownloadTestJs.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-download-test-js:snapshot
             ports:
                 - "8090:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginSubmitExcel2SBOL.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-submit-excel2sbol:snapshot
             ports:
                 - "8098:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginSubmitTest.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-submit-test:snapshot
             ports:
                 - "8087:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginSubmitTestJs.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-submit-test-js:snapshot
             ports:
                 - "8091:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginVisualSeqviz.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,4 @@ services: @@
           - "8085:5050"
         environment:
           - SEQVIZ_HOST=http://localhost:8085/
-        dns:
-          - 8.8.8.8
         restart: always

docker-compose.pluginVisualServeTest.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,5 +7,4 @@ services: @@
                 - "8088:5000"
             environment:
                 - SERVER_HOST=http://localhost:8088/
-            dns: 8.8.8.8
             restart: always

docker-compose.pluginVisualServeTestJs.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -8,4 +8,3 @@ services: @@
             environment:
                 - SERVER_HOST=http://localhost:8086/
             restart: always
-            dns: 8.8.8.8

docker-compose.pluginVisualTest.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -6,4 +6,3 @@ services: @@
             ports:
                 - "8081:5000"
             restart: always
-            dns: 8.8.8.8

docker-compose.pluginVisualTestJs.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,4 @@ services: @@
             image: synbiohub/plugin-visual-test-js:snapshot
             ports:
                 - "8082:5000"
-            dns: 8.8.8.8
             restart: always

docker-compose.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -28,10 +28,9 @@ services: @@
             image: synbiohub/sbh3frontend:snapshot
             ports:
                 - "3333:3333"
-            dns: 8.8.8.8
             restart: always
             environment:
-                - backend=http://localhost:7777
+                - backend=${SYNBIOHUB_BACKEND:-http://localhost:7777}
                 - backendSS=http://synbiohub:7777
         synbiohub:
             image: synbiohub/synbiohub:snapshot-standalone
@@ Expand All / @@ -46,7 +45,6 @@ services: @@
                 - type: volume
                   source: virtuoso-db1
                   target: /virtuoso
-            dns: 8.8.8.8
             restart: always
     volumes:
@@ Expand Down @@

Provide feedback