470 export section people #498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| readonly requiredFields: string[]; | ||
| readonly lazyReferences: string[]; | ||
| readonly subsections: DisplaySubsectionView[]; | ||
| readonly exportViews: ExportView[]; |
There was a problem hiding this comment.
Is this required? If not, I think the addition to the export domain model should be removed.
kaladay
requested changes
Oct 24, 2025
| addExportToQueryParams(queryParams, section); | ||
| const tree = this.router.createUrlTree([''], { queryParams }); | ||
| const query = tree.toString().substring(1); | ||
| return `${this.appConfig.serviceUrl}/individual/${this.individual?.id}/export${query}&view=${section.name}`; |
There was a problem hiding this comment.
This code:
return `${this.appConfig.serviceUrl}/individual/${this.individual?.id}/export${query}&view=${section.name}`;I'm not sure about this line.
When ${this.individual?.id} is undefined, then the URL generated will have double slashes.
If there is no individual, will this URL be valid?
${this.appConfig.serviceUrl}/individual/export${query}&view=${section.name}If so, then I suggest conditionally adding both the id AND the forward slash based on the same condition.
If not, then what URL should be used?
There was a problem hiding this comment.
This component would not render without an individual. The does not require optional chaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added export button to section : people.
Created export link using getSectionExportUrl for exporting the people directory.
added the boolean check - hasExport(section) check to conditionally display export option.
Added css style for the export button.
Type of change
Please delete options that are not relevant.
Testing Procedures
Tested this on local set up