Skip to content

Disable unimplemented tests #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

Disable unimplemented tests #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864dfa5
add todo markers for disabled tests.
tasansal Sep 8, 2025
ef14546
set coverage minimum to 85% due to disabled tests
tasansal Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ relative_files = true

[tool.coverage.report]
show_missing = true
fail_under = 90
fail_under = 85
exclude_also = [
"if __name__ == __main__:",
"if TYPE_CHECKING:",
Expand Down
5 changes: 5 additions & 0 deletions tests/integration/test_segy_import_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
dask.config.set(scheduler="synchronous")


# TODO(Altay): Finish implementing these grid overrides.
# https://github.com/TGSAI/mdio-python/issues/612
@pytest.mark.skip(reason="NonBinned and HasDuplicates haven't been properly implemented yet.")
@pytest.mark.parametrize("grid_override", [{"NonBinned": True}, {"HasDuplicates": True}])
@pytest.mark.parametrize("chan_header_type", [StreamerShotGeometryType.C])
class TestImport4DNonReg:
Expand Down Expand Up @@ -161,6 +164,8 @@ def test_import_4d_segy( # noqa: PLR0913
assert "This grid is very sparse and most likely user error with indexing." in str(execinfo.value)


# TODO(Altay): Finish implementing these grid overrides.
# https://github.com/TGSAI/mdio-python/issues/612
@pytest.mark.skip(reason="AutoShotWrap requires a template that is not implemented yet.")
@pytest.mark.parametrize("grid_override", [{"AutoChannelWrap": True}, {"AutoShotWrap": True}, None])
@pytest.mark.parametrize("chan_header_type", [StreamerShotGeometryType.A, StreamerShotGeometryType.B])
Expand Down
3 changes: 3 additions & 0 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def runner() -> CliRunner:
return CliRunner()


# TODO(Altay): Redesign and implement the new v1 CLI
# https://github.com/TGSAI/mdio-python/issues/646
@pytest.mark.skip(reason="CLI hasn't been updated to work with v1 yet.")
@pytest.mark.dependency
def test_main_succeeds(runner: CliRunner, segy_input: Path, zarr_tmp: Path) -> None:
"""It exits with a status code of zero."""
Expand Down
Loading