Skip to content

Conversation

@markspec
Copy link
Contributor

Add prestack schema to allow more efficient data access and more logical data layout. Aligns with auto-shot wrap ingestion. This is required for efficient processing and imaging of individual shotline/gun combinations and visualization of common channel gathers.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 96.73203% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.34%. Comparing base (c3ba558) to head (0d77df4).
⚠️ Report is 215 commits behind head on main.

Files with missing lines Patch % Lines
src/mdio/segy/utilities.py 40.00% 2 Missing and 1 partial ⚠️
src/mdio/segy/geometry.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   85.30%   88.34%   +3.03%     
==========================================
  Files          46       90      +44     
  Lines        2219     4942    +2723     
  Branches      306      324      +18     
==========================================
+ Hits         1893     4366    +2473     
- Misses        281      501     +220     
- Partials       45       75      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell
Copy link
Collaborator

Name suggestion: PreStackStreamerFieldRecords3DTime

@BrianMichell BrianMichell changed the title 624 prestack schema Add Seismic3DPreStackStreamerFieldRecords template Oct 21, 2025
@BrianMichell BrianMichell added the enhancement New feature or request label Oct 21, 2025
@BrianMichell BrianMichell linked an issue Oct 21, 2025 that may be closed by this pull request
@tasansal tasansal force-pushed the 624_prestack_schema branch 2 times, most recently from 7d846f8 to 8c5ffab Compare October 29, 2025 19:23
@tasansal tasansal changed the title Add Seismic3DPreStackStreamerFieldRecords template Add Seismic3DStreamerFieldRecords template Oct 29, 2025
@tasansal tasansal force-pushed the 624_prestack_schema branch 2 times, most recently from 767a399 to 019d977 Compare November 3, 2025 14:44
@tasansal tasansal requested a review from BrianMichell November 4, 2025 01:14
@tasansal
Copy link
Collaborator

tasansal commented Nov 4, 2025

@markspec @BrianMichell I've upgraded the template with some nice features and more clear data structure in general. Logic stays the same. Please re-review.

Mainly introduced:

  • Computed dimensions (e.g. grid override result)
  • Handling calculated dimension in ingestion
  • shot_index a dimension instead of shot_point to not overload the name
  • shot_index is made zero based. It wasn't before which could cause sparse grid
  • shot_point is meaningful as the original and is based on sail_line, gun, shot_index dims
  • Renamed shot_line to sail_line

The calculated dimension will come in handy for NonBinned override as well. We can rename the dimension to dim_index and reuse this same logic too while keeping the original name as a coordinate similar to here.

@tasansal tasansal force-pushed the 624_prestack_schema branch from 745790e to 0d77df4 Compare November 6, 2025 21:57
@tasansal tasansal merged commit 22e1784 into TGSAI:main Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PreStack schema

4 participants