Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

Per #612 CalculateCable is no longer required. This PR removes associated source code, tests, and documentation regarding it.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (c3ba558) to head (6eb04be).
⚠️ Report is 176 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
+ Coverage   85.30%   86.81%   +1.50%     
==========================================
  Files          46       82      +36     
  Lines        2219     4535    +2316     
  Branches      306      301       -5     
==========================================
+ Hits         1893     3937    +2044     
- Misses        281      522     +241     
- Partials       45       76      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tasansal
Copy link
Collaborator

tasansal commented Oct 1, 2025

@BrianMichell when i merged #698 this has conflicts, can you please resolve. thanks.

@BrianMichell
Copy link
Collaborator Author

Yeah, I figured that would happen after I raised both. Resolved the issues but we did lose test_missing_param and test_incompatible_overrides due to pre-commit rules which I did not expect.

@tasansal tasansal added the refactoring Refactoring label Oct 1, 2025
Copy link
Collaborator

@tasansal tasansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasansal tasansal merged commit 9b20936 into TGSAI:main Oct 1, 2025
10 checks passed
@BrianMichell BrianMichell deleted the DeprecateCalculateCable branch October 3, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants