Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

Implements a very simple validator.

@tasansal Let me know if you want extensive testing.

@BrianMichell BrianMichell added bug Something isn't working v1 labels Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.98%. Comparing base (c3ba558) to head (83d71ac).
⚠️ Report is 185 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   85.30%   88.98%   +3.67%     
==========================================
  Files          46       84      +38     
  Lines        2219     4504    +2285     
  Branches      306      296      -10     
==========================================
+ Hits         1893     4008    +2115     
- Misses        281      427     +146     
- Partials       45       69      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@tasansal tasansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brian, the logic looks good. However, the implementation can be simplified with by using sets. This will eliminate the looping etc. can you change it like that? thanks.

@tasansal tasansal force-pushed the 703_validate_spec_for_keys branch from 68e67e7 to 2f4d681 Compare October 8, 2025 17:57
Copy link
Collaborator

@tasansal tasansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add 2 simple unit tests for this func. One that passes validation, and one that fails.

@tasansal tasansal changed the title Implement validation for all required fields Implement SEG-Y header validation for required template keys Oct 8, 2025
@tasansal tasansal self-requested a review October 8, 2025 20:44
@tasansal tasansal merged commit a664dbd into TGSAI:main Oct 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants