-
Notifications
You must be signed in to change notification settings - Fork 15
Implement SEG-Y header validation for required template keys #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 85.30% 88.98% +3.67%
==========================================
Files 46 84 +38
Lines 2219 4504 +2285
Branches 306 296 -10
==========================================
+ Hits 1893 4008 +2115
- Misses 281 427 +146
- Partials 45 69 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasansal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brian, the logic looks good. However, the implementation can be simplified with by using sets. This will eliminate the looping etc. can you change it like that? thanks.
68e67e7 to
2f4d681
Compare
tasansal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add 2 simple unit tests for this func. One that passes validation, and one that fails.
Implements a very simple validator.
@tasansal Let me know if you want extensive testing.