Fix assignment of MemberGenericArguments #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuelWalz
force-pushed
the
fix/use-intended-member-generic-arguments
branch
from
80653f6 to
2392b39
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 258 258
Lines 19226 19226
Branches 1606 1606
=======================================
Hits 14926 14926
Misses 3845 3845
Partials 455 455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ManuelWalz
force-pushed
the
fix/use-intended-member-generic-arguments
branch
from
2392b39 to
ebc6650
Compare
ManuelWalz
force-pushed
the
fix/use-intended-member-generic-arguments
branch
from
ebc6650 to
3cbfe64
Compare
… from commit f80d9aa Signed-off-by: Manuel Walz <Manuel.Walz@andrena.de>
ManuelWalz
force-pushed
the
fix/use-intended-member-generic-arguments
branch
from
3cbfe64 to
db01106
Compare
alexanderlinne
approved these changes
Sep 26, 2025
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion there where some changes in commit f80d9aa that led to generic arguments inside of method calls to not be detected correctly. For example if there is method inside a class which calls a method with generic arguments from a different class. Those generic arguments from the called method will not correctly show up in the dependencies.