-
Notifications
You must be signed in to change notification settings - Fork 10
Analog write primitive #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29000c0 to
adee735
Compare
carllocos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity is the analogWrite a newly supported function for the ESP32?
The reason why I ask is because I recall that such a function was not supported for the ESP32 which is also the reason why I wrote the previous primitive chip_analog_write (now renamed to chip_ledc_set_duty). Now seeing you use the Arduino analogWrite makes me doubt whether I overlooked its existence.
I thought so. I'll double check. If not, that does pose a conundrum. Do all the Arduino primitives need to be supported for the ESP? Ideally, I'd say yes, but the counter argument is that real Arduino devices may want to use this primitives. That is an annoying decision we will continue to encounter as long as we haven't added a modular system. |
|
@tolauwae I think the
Agree so maybe for the time being we should ignore this issue since this will naturally resolve when switching to a modular system. |
|
But compilation works this time around. All CI checks are green. I'll double check if it works for the fade example tomorrow. |
|
@carllocos the primitive works fine on ESP32. I actually used it in code for the MobiSys demo. |
Add the
analog_writeprimitive.