Fix step over not stepping if at a breakpoint placed on a call instruction #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolauwae
force-pushed
the
fix/step-over-call-at-breakpoint
branch
from
87c0b32 to
82d14b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step over does not work if the current opcode is a call instruction and there is a breakpoint on it. The
handleSTEPfunction skips breakpoints but if the current opcode is a call or indirect call instruction we just set a mark and put the vm in running state. If the current pc is a breakpoint the vm never goes any further because it instantly hits the breakpoint.