Skip to content

Conversation

@MaartenS11
Copy link
Member

Adds the primitive mocking debugging interrupts that make it possible to set the return value for a primitive with one argument. Mocked primitives are also visible in the snapshots so that restoring a snapshot from the past also removes any primitives mocked using future values.

But now they are better as they work at the VM level and are not just a little bit of code inside a primitive. They also override primitive + argument combinations instead of just overriding a pin which only works for analog and digital read primitives.
This makes them work well with time travelling so a decision in the future doesn't affect the past anymore when stepping back in time.
@tolauwae tolauwae self-requested a review October 30, 2024 14:48
Copy link
Member

@tolauwae tolauwae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@tolauwae tolauwae marked this pull request as ready for review October 30, 2024 14:51
@MaartenS11 MaartenS11 merged commit 35bdf7b into main Oct 30, 2024
15 checks passed
@MaartenS11 MaartenS11 deleted the feat/primitive-mocking branch October 30, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants