Skip to content

WIP: Add E8011 discouraging shlex.quote() usages on Windows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2021
Merged

WIP: Add E8011 discouraging shlex.quote() usages on Windows #7

merged 5 commits into from
Jul 18, 2021

Conversation

@HorlogeSkynet
Copy link
Contributor

@HorlogeSkynet HorlogeSkynet commented Jul 17, 2021 •
edited
Loading

TODO : write Pylint tests

See #5.

@HorlogeSkynet HorlogeSkynet mentioned this pull request Jul 17, 2021
Closed
9 tasks
@HorlogeSkynet HorlogeSkynet changed the title WIP: Add E8010 discouraging shlex.quote() usages on Windows WIP: Add E8011 discouraging shlex.quote() usages on Windows Jul 17, 2021
@coveralls
Copy link

coveralls commented Jul 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1042677452

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1040671333: 0.0%
Covered Lines: 135
Relevant Lines: 135
💛 - Coveralls

@Takishima
Copy link
Owner

Takishima commented Jul 17, 2021

I have some ideas on how to mock the os module. I will add those commits tomorrow.

@Takishima Takishima marked this pull request as ready for review July 18, 2021 15:25
@Takishima Takishima merged commit 9d10919 into Takishima:main Jul 18, 2021
@HorlogeSkynet HorlogeSkynet deleted the discourage/shlex-quote_on_windows branch July 19, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Takishima Takishima Takishima approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HorlogeSkynet @coveralls @Takishima