-
Notifications
You must be signed in to change notification settings - Fork 129
Fix TypeScript type resolution for QueryCollectionConfig when using queryCollectionOptions without a schema. #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KyleAMathews
wants to merge
1
commit into
main
Choose a base branch
from
claude/debug-collection-config-type-01NBgHjsUa6E2RxrovE67ixk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+132
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0be0c9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
…ectionConfig
Fixed TypeScript type resolution issue where QueryCollectionConfig failed to recognize
inherited properties (getKey, onInsert, onUpdate, etc.) when using queryCollectionOptions
without a schema.
The issue was caused by QueryCollectionConfig extending BaseCollectionConfig while also
having a conditional type for the queryFn property. TypeScript couldn't properly resolve
the inherited properties in this scenario.
Solution: Changed QueryCollectionConfig to use Omit<BaseCollectionConfig, ...> pattern,
consistent with ElectricCollectionConfig and PowerSyncCollectionConfig.
Changes:
- Refactored QueryCollectionConfig to use Omit pattern for consistency
- Explicitly declares mutation handlers with custom return type { refetch?: boolean }
- Removed unused imports (StringCollationConfig, SyncMode)
- Added test cases to verify no-schema usage works correctly
52fe64e to
0be0c9a
Compare
Contributor
|
Size Change: 0 B Total Size: 85.8 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.34 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
QueryCollectionConfiginterface extendedBaseCollectionConfig, but TypeScript failed to resolve inherited properties likegetKey,onInsert,onUpdate, etc. when the interface contained a conditional type for thequeryFnproperty. This caused type errors when trying to usequeryCollectionOptionswithout a schema.See this discussion https://discord.com/channels/719702312431386674/1438802082382483496/1438802082382483496