-
-
Notifications
You must be signed in to change notification settings - Fork 534
fix(react-form): widen return type of render prop #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7b913e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 7b913e8
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
===========================================
- Coverage 90.35% 51.91% -38.45%
===========================================
Files 38 14 -24
Lines 1752 183 -1569
Branches 444 29 -415
===========================================
- Hits 1583 95 -1488
+ Misses 149 77 -72
+ Partials 20 11 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also LGTM! The code coverage appears to complain, but this isn't affected by this PR.
Fixes: #1815
🎯 Changes
In React
JSX.Element
is only a subset of the valid children described byReactNode
. By widening this type we allow returning all valid React children now in a non-breaking fashion allowingto work without TypeScript errors.
✅ Checklist
pnpm test:pr
.🚀 Release Impact