Replies: 2 comments
-
|
sounds easy enough to implement. I'd accept adding a callback for custom behavior. Don't know how'd that appear in the devtools, but that's a minor issue. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hey, guys.
Have a thought regarding conflicts during registration.
What if I want to log not just to local console, but to external service? e.g. to Sentry. You see, if I make hotkey on component level rather than centralized on top-most(aka "page") level, I may have conflicts I never assumed initially. Logging into external service would be a canary in the mine.
Another use-case - showing tooltip to the end-user, "Sorry, this specific shortcut will not work. It's not about you, it's on us".
Finally, but this rather sounds silly, we could decide whether to throw and unregister or allow both on case-by-case basis, up to some extra logic. Don't ask me if I have something in mind 😅 Probably, I just wanted to have 3rd case in the list that bad.
How does it sound?
PS if that sounds reasonable I would make a PR :)
Beta Was this translation helpful? Give feedback.
All reactions