Skip to content

Commit 5760f70

Browse files
ci: remove test:format from Nx workflow (#7775)
1 parent ffd404f commit 5760f70

File tree

6 files changed

+16
-23
lines changed

6 files changed

+16
-23
lines changed

.github/workflows/autofix.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- name: Checkout
21-
uses: actions/checkout@v4
21+
uses: actions/checkout@v4.1.7
2222
- name: Setup Tools
23-
uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517
23+
uses: tanstack/config/.github/setup@main
2424
- name: Fix formatting
2525
run: pnpm prettier:write
2626
- name: Apply fixes
27-
uses: autofix-ci/action@dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a
27+
uses: autofix-ci/action@ff86a557419858bb967097bfc916833f5647fa8c
2828
with:
2929
commit-message: 'ci: apply automated fixes'

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ permissions:
2323
jobs:
2424
test-and-publish:
2525
name: Test & Publish
26-
if: github.repository == 'TanStack/query'
26+
if: github.repository_owner == 'TanStack'
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Checkout
30-
uses: actions/checkout@v4
30+
uses: actions/checkout@v4.1.7
3131
with:
3232
fetch-depth: 0
3333
- name: Start Nx Agents
3434
run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml"
3535
- name: Setup Tools
36-
uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517
36+
uses: tanstack/config/.github/setup@main
3737
- name: Run Tests
3838
run: pnpm run test:ci --parallel=3
3939
- name: Stop Nx Agents
@@ -50,7 +50,7 @@ jobs:
5050
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
5151
TAG: ${{ inputs.tag }}
5252
- name: Upload coverage to Codecov
53-
uses: codecov/codecov-action@v4
53+
uses: codecov/codecov-action@v4.5.0
5454
with:
5555
directory: packages
5656
env:

.github/workflows/labeler.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ jobs:
77
triage:
88
runs-on: ubuntu-latest
99
steps:
10-
- uses: actions/labeler@v4
10+
- uses: actions/labeler@v4.3.0
1111
with:
1212
repo-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ name: pr
22

33
on:
44
pull_request:
5-
paths-ignore:
6-
- 'media/**'
75

86
concurrency:
97
group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
@@ -21,15 +19,15 @@ jobs:
2119
runs-on: ubuntu-latest
2220
steps:
2321
- name: Checkout
24-
uses: actions/checkout@v4
22+
uses: actions/checkout@v4.1.7
2523
with:
2624
fetch-depth: 0
2725
- name: Start Nx Agents
2826
run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml"
2927
- name: Setup Tools
30-
uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517
28+
uses: tanstack/config/.github/setup@main
3129
- name: Get base and head commits for `nx affected`
32-
uses: nrwl/nx-set-shas@v4
30+
uses: nrwl/nx-set-shas@v4.0.6
3331
with:
3432
main-branch-name: main
3533
- name: Run Checks
@@ -38,7 +36,7 @@ jobs:
3836
if: ${{ always() }}
3937
run: npx nx-cloud stop-all-agents
4038
- name: Upload coverage to Codecov
41-
uses: codecov/codecov-action@v4
39+
uses: codecov/codecov-action@v4.5.0
4240
with:
4341
directory: packages
4442
env:
@@ -48,11 +46,11 @@ jobs:
4846
runs-on: ubuntu-latest
4947
steps:
5048
- name: Checkout
51-
uses: actions/checkout@v4
49+
uses: actions/checkout@v4.1.7
5250
with:
5351
fetch-depth: 0
5452
- name: Setup Tools
55-
uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517
53+
uses: tanstack/config/.github/setup@main
5654
- name: Build Packages
5755
run: pnpm run build:all
5856
- name: Publish Previews

nx.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323
]
2424
},
2525
"targetDefaults": {
26-
"test:format": {
27-
"cache": true,
28-
"inputs": ["{workspaceRoot}/**/*"]
29-
},
3026
"test:knip": {
3127
"cache": true,
3228
"inputs": ["{workspaceRoot}/**/*"]

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
"clean": "pnpm --filter \"./packages/**\" run clean",
1212
"preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...')} else {process.exit(1)}\" || npx -y only-allow pnpm",
1313
"test": "pnpm run test:ci",
14-
"test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build",
15-
"test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build",
14+
"test:pr": "nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build",
15+
"test:ci": "nx run-many --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build",
1616
"test:eslint": "nx affected --target=test:eslint --exclude=examples/**",
1717
"test:format": "pnpm run prettier --check",
1818
"test:sherif": "sherif -p \"./integrations/*\" -p \"./examples/*\"",
@@ -32,7 +32,6 @@
3232
},
3333
"nx": {
3434
"includedScripts": [
35-
"test:format",
3635
"test:sherif",
3736
"test:knip"
3837
]

0 commit comments

Comments
 (0)