Feature/disable context sharing#1912
Merged
TkDodo merged 5 commits intoTanStack:masterfrom Mar 8, 2021
TkDodo:feature/disable-context-sharing
Merged
Feature/disable context sharing#1912TkDodo merged 5 commits intoTanStack:masterfrom TkDodo:feature/disable-context-sharing
TkDodo merged 5 commits intoTanStack:masterfrom
TkDodo:feature/disable-context-sharing
Conversation
but still allow for it by adding a `contextSharing` boolean prop when creating the QueryClient context
I somehow lost the return statement
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/3Z6gRW7VCE9EoY4486Yv7jHA7e2C |
Collaborator
Author
|
since this feature wasn't really documented anywhere, I think we could ship this as a minor version. |
tannerlinsley
approved these changes
Mar 5, 2021
adamgajzlerowicz
approved these changes
Mar 8, 2021
Member
|
🎉 This PR is included in version 3.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #1764, this PR disables context sharing per default, and allows to enable it via a
contextSharing: booleanprop on theQueryClientProvider.I also tried to document it, mainly using the comment @tannerlinsley wrote in the code 😁