fix(eslint-plugin): strictly type config keys #7780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedBaset
reviewed
Jul 24, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85e36fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
TkDodo
approved these changes
Jul 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7780 +/- ##
===========================================
+ Coverage 44.58% 84.00% +39.41%
===========================================
Files 185 11 -174
Lines 7078 350 -6728
Branches 1566 129 -1437
===========================================
- Hits 3156 294 -2862
+ Misses 3559 42 -3517
+ Partials 363 14 -349
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #7766.
While the changes made in #7766 are a good step forward to having a properly typed config, it still doesn't fully work and properly represent the actual code. This PR aims to change that.
With the changes from #7766 pulled in users still run into a typing issue as shown below. This is because of the union of
ESLint.ConfigData | Linter.FlatConfigcannot be spread, because they are objects and not arrays. By strictly specifying the types of the different keys this can be resolved.With this change the config is fully compatible and no
ts-expect-error/ts-ignorewill be required: