feat(eslint-plugin): use typescript-eslint v8 stable #7968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8390136. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
commit: @tanstack/angular-query-devtools-experimental
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
More templates
|
Collaborator
|
now types are failing :/ |
rivajunior
force-pushed
the
update-tanstackeslint-plugin-query-to-use-typescript-eslintutils-stable-v8
branch
from
28e5649 to
e1c48bb
Compare
rivajunior
commented
Aug 27, 2024
packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts
Outdated
Show resolved
Hide resolved
…pescript-eslintutils-stable-v8
lachlancollins
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7968 +/- ##
==========================================
+ Coverage 45.08% 45.09% +0.01%
==========================================
Files 188 188
Lines 7147 7149 +2
Branches 1605 1607 +2
==========================================
+ Hits 3222 3224 +2
Misses 3562 3562
Partials 363 363 |
lachlancollins
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanstack/eslint-plugin-query is currently setting the dependency for @typescript-eslint/utils to use v8.0.0-alpha.30.
As typescript-eslint has released the stable v8, this project could use @typescript-eslint/rule-tester and @typescript-eslint/utils with version ^8.3.0, requiring the peerDependencies for ESLint to be changed to ^8.57.0 || ^9.0.0.
reference: #7967