Added missing type="button" on DevTools-button#8016
Merged
TkDodo merged 2 commits intoTanStack:mainfrom Sep 8, 2024
Svish:patch-1
Merged
Added missing type="button" on DevTools-button#8016TkDodo merged 2 commits intoTanStack:mainfrom Svish:patch-1
type="button" on DevTools-button#8016TkDodo merged 2 commits intoTanStack:mainfrom
Svish:patch-1
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4d2fe9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
More templates
@tanstack/angular-query-devtools-experimental
@tanstack/eslint-plugin-query
@tanstack/angular-query-experimental
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/vue-query
@tanstack/svelte-query-persist-client
@tanstack/vue-query-devtools
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8016 +/- ##
=======================================
+ Coverage 0 5.05% +5.05%
=======================================
Files 0 17 +17
Lines 0 1385 +1385
Branches 0 453 +453
=======================================
+ Hits 0 70 +70
- Misses 0 1145 +1145
- Partials 0 170 +170
|
Contributor
Author
|
Um... how can adding |
TkDodo
approved these changes
Sep 8, 2024
This was referenced Sep 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Button type attribute has not been set"-issue reported by Edge DevTools.