Skip to content

fix: handle nullish coalescing operator in exhaustive-deps rule #8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TkDodo merged 2 commits into from
Oct 8, 2024
Merged

fix: handle nullish coalescing operator in exhaustive-deps rule #8146

TkDodo merged 2 commits into from
Oct 8, 2024

Conversation

@Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Oct 8, 2024

fixes #8131

Ensure that the exhaustive-deps rule correctly handles cases where the nullish coalescing operator (??) is used in query functions.

Example test case:

useQuery({
  queryKey: ["foo", options],
  queryFn: () => options?.params ?? options
});

fix: handle nullish coalescing operator in exhaustive-deps rule
060fdb7 
Ensure that the exhaustive-deps rule correctly handles cases where the nullish coalescing operator (??) is used in query functions.

Example test case:
@Newbie012 Newbie012 requested a review from TkDodo October 8, 2024 10:29
@nx-cloud
Copy link

nx-cloud bot commented Oct 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e1774a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8146

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8146

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8146

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8146

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8146

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8146

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8146

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8146

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8146

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8146

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8146

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8146

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8146

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8146

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8146

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8146

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8146

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8146

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8146

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8146

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8146

commit: 4e1774a

@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (495b086) to head (4e1774a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #8146       +/-   ##
=========================================
+ Coverage      0   87.82%   +87.82%     
=========================================
  Files         0       15       +15     
  Lines         0      493      +493     
  Branches      0      183      +183     
=========================================
+ Hits          0      433      +433     
- Misses        0       46       +46     
- Partials      0       14       +14
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 87.82% <100.00%> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit c232a6f into main Oct 8, 2024
@TkDodo TkDodo deleted the fix-nullish-coalescing-operator branch October 8, 2024 12:30
@TkDodo TkDodo mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eslint-plugin: problems with optional chaining

3 participants

@Newbie012 @TkDodo